Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm/syncer : fix unstable test in shardddl1 #3471

Merged
merged 2 commits into from
Nov 17, 2021
Merged

dm/syncer : fix unstable test in shardddl1 #3471

merged 2 commits into from
Nov 17, 2021

Conversation

WizardXiao
Copy link
Contributor

What problem does this PR solve?

fix https://github.com/pingcap/ticdc/issues/3398

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

Please add a release note.
If you don't think this PR needs a release note then fill it with `None`.

@WizardXiao WizardXiao added the area/dm Issues or PRs related to DM. label Nov 16, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2021
@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@WizardXiao
Copy link
Contributor Author

/run-dm-compatibility-test

@WizardXiao
Copy link
Contributor Author

/run-kafka-integration-test

@WizardXiao
Copy link
Contributor Author

/run-integration-test

@WizardXiao
Copy link
Contributor Author

/run-kafka-integration-test

@lance6716 lance6716 changed the title dm/syncer : fix instability test in shardddl1 dm/syncer : fix unstable test in shardddl1 Nov 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2021
@WizardXiao
Copy link
Contributor Author

/run-integration-test

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021 •
edited
Loading

Codecov Report

Merging #3471 (b4a0f23) into master (24030f8) will increase coverage by 1.1263%.
The diff coverage is 67.8657%.

@@               Coverage Diff                @@
##             master      #3471        +/-   ##
================================================
+ Coverage   56.5356%   57.6619%   +1.1263%     
================================================
  Files           211        233        +22     
  Lines         22798      23832      +1034     
================================================
+ Hits          12889      13742       +853     
- Misses         8598       8699       +101     
- Partials       1311       1391        +80

Ehco1996
Ehco1996 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2021
@Ehco1996
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cdae43

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2021
@ti-chi-bot ti-chi-bot merged commit faa070d into pingcap:master Nov 17, 2021
glorv pushed a commit to glorv/ticdc that referenced this pull request Nov 17, 2021
@WizardXiao @glorv
dm/syncer : fix unstable test in shardddl1 (pingcap#3471)
0d4e976
@glorv glorv mentioned this pull request Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log doesn't contain fail to delete shard DDL infos and lock operations
5 participants
@WizardXiao @ti-chi-bot @codecov-commenter @Ehco1996 @lance6716